Change in vdsm[master]: libvirtvm: allow acpi again

danken at redhat.com danken at redhat.com
Tue Aug 28 11:58:27 UTC 2012


Dan Kenigsberg has uploaded a new change for review.

Change subject: libvirtvm: allow acpi again
......................................................................

libvirtvm: allow acpi again

Commit c3e2272f has mistakenly changed

        <features>
                <acpi/>
        </features>

into

        <features>
                acpi
        </features>

which caused VMs to start up silently with no acpi support. This patch
reverts the offending part of the above commit.

Bug initially reported by Itzik Brown.

Change-Id: I591c40678f030f1bcd4cb7cb42c21907420f7cf1
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/7533/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index a975206..c29a1a9 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -726,7 +726,8 @@
         <features/>
         """
         if utils.tobool(self.conf.get('acpiEnable', 'true')):
-            self.appendChildWithText('features', 'acpi')
+            self.dom.appendChild(self.doc.createElement('features')) \
+               .appendChild(self.doc.createElement('acpi'))
 
     def appendCpu(self):
         """


--
To view, visit http://gerrit.ovirt.org/7533
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I591c40678f030f1bcd4cb7cb42c21907420f7cf1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list