Change in vdsm[master]: [WIP] Remove the domain weakref cache and parallelize _findD...
abaron at redhat.com
abaron at redhat.com
Mon Aug 27 23:50:45 UTC 2012
Ayal Baron has posted comments on this change.
Change subject: [WIP] Remove the domain weakref cache and parallelize _findDomain
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sdc.py
Line 65: self.__domainCache = {}
Line 66: self.__inProgress = set()
Line 67: self.storage_repo = storage_repo
Line 68:
Line 69: def invalidateStorage(self):
invalidateStorage is called from hsm.py (under connectStorageServer)
Once it used to call refreshStorage, but that was very heavy and if multiple connectStorageServer commands were called sequentially it took a long time for no reason, so invalidate was called instead and then following a series of connects any verb that called produce caused the refresh to happen once.
Reviewing the flows now though I think this method should be removed - lvm.invalidateCache should be moved down to refresh() and hsm should call that instead if anything at all.
Currently though the flow seems wrong.
Line 70: lvm.invalidateCache()
Line 71:
Line 72: @misc.samplingmethod
Line 73: def refreshStorage(self):
--
To view, visit http://gerrit.ovirt.org/7511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a04babcfbb5620e9e703fe94a1ae681ac300bfb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list