Change in vdsm[master]: Upgrade a data domain on attachSD when required
fsimonce at redhat.com
fsimonce at redhat.com
Mon Aug 27 22:05:56 UTC 2012
Federico Simoncelli has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 933: domVers = dom.getVersion()
Line 934: mstVers = self.masterDomain.getVersion()
Line 935:
Line 936: # If you remove this condition, remove it from
Line 937: # public_createStoragePool too.
Because I thought we didn't want to allow to create storage pools with mixed versions (but it might be handy). Now that I think of it we might hit that also if a storage domain didn't complete the upgrade and you want to create a new storage pool out of that (once detached). I'll check if that's a valid flow too.
Line 938: if dom.isData() and domVers > mstVers:
Line 939: raise se.MixedSDVersionError(dom.sdUUID, domVers,
Line 940: self.masterDomain.sdUUID, mstVers)
Line 941:
--
To view, visit http://gerrit.ovirt.org/7444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65dfd6dd339569fbaf276f3942a001c174423b1a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list