Change in vdsm[master]: Define network filter on libvirt

danken at redhat.com danken at redhat.com
Mon Aug 27 21:22:05 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Define network filter on libvirt
......................................................................


Patch Set 5: Looks good to me, approved

(1 inline comment)

Thanks!

....................................................
File vdsm/nwfilter.py
Line 30:     Defines network filters on libvirt
Line 31:     """
Line 32:     conn = libvirtconnection.get()
Line 33:     NoMacSpoofingFilter().defineNwFilter(conn)
Line 34:     conn.close()
someone told me that it is not uncommon for conn.close() to fail. we may need to either fix the issue, or swallow it. but let us postpone this to a future patch.
Line 35: 
Line 36: class NwFilter(object):
Line 37:     """
Line 38:     Base class for custom network filters


--
To view, visit http://gerrit.ovirt.org/7354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1708385dec6a87bc404e4ab25c4da8ab8a8acc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list