Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Mon Aug 27 09:53:45 UTC 2012
Michal Skrivanek has posted comments on this change.
Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File vdsm/vdsmd.init.in
Line 305: if [ "$force_reconfigure" != "force" ] &&
Line 306: grep -q "$by_vdsm_vers" $lconf && grep -q "$by_vdsm_vers" $qconf && \
Line 307: grep -q "$by_vdsm_vers" $ldconf && grep -q "$by_vdsm_vers" $qlconf
Line 308: then
Line 309: debug_log "no reconfigure proccedded"
typo, I guess?
Line 310: log_success_msg $"$prog: libvirt already configured for vdsm "
Line 311: return 0
Line 312: fi
Line 313:
Line 425: }
Line 426:
Line 427: stop_libvirtd_sysv() {
Line 428: # stop libvirt SysV service if we intend to configure upstart
Line 429: if ! upstart_libvirt; then
then why keep this function around? At minimum please put a comment it's not actually used.
Line 430: debug_log "stopping libvirt service.."
Line 431: /sbin/chkconfig libvirtd off
Line 432: /sbin/service libvirtd stop
Line 433: fi
--
To view, visit http://gerrit.ovirt.org/7331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list