Change in vdsm[master]: improve message when trying to attach import domain with wro...

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Aug 26 12:04:06 UTC 2012


Eduardo has posted comments on this change.

Change subject: improve message when trying to attach import domain with wrong permissions
......................................................................


Patch Set 12: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/storageServer.py
Line 181:         self._mount.mount(self.options, self._vfsType)
Line 182: 
Line 183:         try:
Line 184:             fileSD.validateDirAccess(self.getMountObj().getRecord().fs_file)
Line 185:         except se.StorageServerAccessPermissionError
':' Where?
Line 186:             try:
Line 187:                 self.disconnect()
Line 188:             except OSError:
Line 189:                 self.log.warn("Error while disconnecting after access problem", exc_info=True)


--
To view, visit http://gerrit.ovirt.org/7339
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76880b1445f259431d7aa691eda676e1210308e4
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list