Change in vdsm[master]: Make libvirtvm.py PEP8 compliant

smizrahi at redhat.com smizrahi at redhat.com
Fri Aug 24 15:14:51 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Make libvirtvm.py PEP8 compliant
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 82:                              config.getint('vars', 'vm_sample_net_window'))
Line 83: 
Line 84:         self.addStatsFunction(self.highWrite, self.updateVolumes,
Line 85:                 self.sampleCpu, self.sampleDisk, self.sampleDiskLatency,
Line 86:                 self.sampleNet)
This is function definition and not function invocation
Line 87: 
Line 88:     def _highWrite(self):
Line 89:         if not self._vm._volumesPrepared:
Line 90:             # Avoid queries from storage during recovery process


Line 142
Line 143
Line 144
Line 145
Line 146
They are not really comments. This is just useless pasted json.


--
To view, visit http://gerrit.ovirt.org/7422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32570c2d1a2efa4a5446caa6d973a10b4c84d996
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list