Change in vdsm[master]: [RFC] Support for GLUSTERFS_DOMAIN

fsimonce at redhat.com fsimonce at redhat.com
Fri Aug 24 09:28:29 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: [RFC] Support for GLUSTERFS_DOMAIN
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2012-07-31 18:41:21 +0530
Line 4: Commit:     Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Line 5: CommitDate: 2012-08-24 14:22:57 +0530
Line 6: 
Line 7: [RFC] Support for GLUSTERFS_DOMAIN
You can leave the [RFC] at this stage.
Line 8: 
Line 9: This patch introduces a new storage domain of type
Line 10: GLUSTERFS_DOMAIN, which uses gluster as the storage backend.
Line 11: 


....................................................
File vdsm/libvirtvm.py
Line 999:             return False
Line 1000: 
Line 1001:     @property
Line 1002:     def blockDev(self):
Line 1003:         if self._blockDev is None and not self.networkDev:
With this check you risk to return None (self._blockDev is None by default).
Line 1004:             try:
Line 1005:                 self._blockDev = utils.isBlockDevice(self.path)
Line 1006:             except:
Line 1007:                 self.log.debug("Unable to determine if the path '%s' is a "


--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list