Change in vdsm[master]: [RFC] Support for GLUSTERFS_DOMAIN

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Thu Aug 23 15:57:06 UTC 2012


Deepak C Shetty has posted comments on this change.

Change subject: [RFC] Support for GLUSTERFS_DOMAIN
......................................................................


Patch Set 2: (10 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 982:         self.truesize = int(kwargs.get('truesize', '0'))
Line 983:         self.apparentsize = int(kwargs.get('apparentsize', '0'))
Line 984:         self.name = self._makeName()
Line 985: 
Line 986:         if self.device in ("cdrom", "floppy") or self.networkDev:
Done.
Line 987:             self._blockDev = False
Line 988:         else:
Line 989:             self._blockDev = None
Line 990: 


Line 992: 
Line 993:     @property
Line 994:     def networkDev(self):
Line 995:         try:
Line 996:             res = self.vmVolInfo['volType'] == "network"
Done
Line 997:         except AttributeError:
Line 998:             # To handle legacy and removable drives.
Line 999:             res = False
Line 1000:         return res


Line 995:         try:
Line 996:             res = self.vmVolInfo['volType'] == "network"
Line 997:         except AttributeError:
Line 998:             # To handle legacy and removable drives.
Line 999:             res = False
Done
Line 1000:         return res
Line 1001: 
Line 1002:     @property
Line 1003:     def blockDev(self):


Line 1000:         return res
Line 1001: 
Line 1002:     @property
Line 1003:     def blockDev(self):
Line 1004:         if self._blockDev is None:
Done
Line 1005:             try:
Line 1006:                 self._blockDev = utils.isBlockDevice(self.path)
Line 1007:             except:
Line 1008:                 self.log.debug("Unable to determine if the path '%s' is a "


....................................................
File vdsm/storage/fileSD.py
Line 39: import supervdsm
Line 40: import mount
Line 41: 
Line 42: REMOTE_PATH = "REMOTE_PATH"
Line 43: OPTIONS = "OPTIONS"
Done
Line 44: 
Line 45: FILE_SD_MD_FIELDS = sd.SD_MD_FIELDS.copy()
Line 46: # TBD: Do we really need this key?
Line 47: FILE_SD_MD_FIELDS[REMOTE_PATH] = (str, str)


Line 121:         self.imageGarbageCollector()
Line 122:         self._registerResourceNamespaces()
Line 123: 
Line 124:     @classmethod
Line 125:     def _prepareMetadata(cls, domPath, sdUUID, domainName, domClass, remotePath, storageType, version,
Done
Line 126:                          options):
Line 127:         """
Line 128:         Prepare all domain's special volumes and metadata
Line 129:         """


....................................................
File vdsm/storage/glusterVolume.py
Line 39:                      'protocol': 'gluster', 'volPort': opt_volport,
Line 40:                      'volTransport': opt_voltrans,
Line 41:                      'volfileServer': volfileServer}
Line 42: 
Line 43:         return vmVolInfo
Done


....................................................
File vdsm/storage/hsm.py
Line 2757:                     })
Line 2758: 
Line 2759:             chain.append(volInfo)
Line 2760: 
Line 2761:         return {'path': chain[-1]['path'], 'vmVolInfo': chain[-1]['vmVolInfo'], 'chain': chain}
Done.
'vmVolInfo': chain[-1]['vmVolInfo'] --> 'info':chain[-1]['volInfo']
Made associated changes in prepareImage and clientIF.py - Done
This also causes class Drive in libvirtvm.py attribute name change....
drive['vmVolInfo'] --> drive['volumeInfo'] and is related changes -- Done
Line 2762: 
Line 2763:     @public
Line 2764:     def teardownImage(self, sdUUID, spUUID, imgUUID, volUUID=None):
Line 2765:         """


....................................................
File vdsm/storage/volume.py
Line 290: 
Line 291:         try:
Line 292:             vars.task.pushRecovery(
Line 293:                 task.Recovery("Share volume rollback: %s" % dstPath, clsModule,
Line 294:                               clsName, "shareVolumeRollback", [dstPath]))
Well it was not, hence i did the pep8 changes.
Reverted them back in the next patch.
Done.
Line 295: 
Line 296:             self._share(dstImgPath)
Line 297: 
Line 298:         except Exception, e:


Line 819:         volume to the VM in a different way than the standard 'path' way.
Line 820:         """
Line 821:         # By default, send path
Line 822:         vmVolInfo = {'volType': 'path', 'path': self.getVolumePath()}
Line 823:         return vmVolInfo
Done
Line 824: 
Line 825:     def getMetaParam(self, key):
Line 826:         """
Line 827:         Get a value of a specific key


--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list