Change in vdsm[master]: BZ#840300: setNetworking() return bridge status

dfediuck at redhat.com dfediuck at redhat.com
Thu Aug 23 15:53:28 UTC 2012


Doron Fediuck has posted comments on this change.

Change subject: BZ#840300: setNetworking() return bridge status
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 728:                 self.status = "FAIL"
Line 729:                 logging.error(self.message)
Line 730:                 #Do not set rc to allow changes from rhev-m.
Line 731:             else:
Line 732:                 self.rc = self._addNetwork(url, port)
Does this mean rc may be set to false?

This will cause installation to fail, whilst in the past we allowed installation to complete so the admin can see the problems, fix it and then try to mitigate bridge creation.
Line 733: 
Line 734:         self._xmlOutput('SetNetworking', self.status, None, None, self.message)
Line 735:         return self.rc
Line 736: 


--
To view, visit http://gerrit.ovirt.org/6875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfea98ed31b536699e9d3d6485f5cb62791adcd5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list