Change in vdsm[master]: add simple VM creation functional test

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Thu Aug 23 11:41:43 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: add simple VM creation functional test
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File tests/functional/vmTests.py
Line 44:         kernelPath = "/boot/vmlinuz-" + kernelVer
Line 45:         initramfsPath = "/boot/initramfs-%s.img" % kernelVer
Line 46:         vmid = str(uuid.uuid4())
Line 47:         conf = {'display': 'vnc',
Line 48:                 'initrd': initramfsPath,
Tried to set display to local, but it causes an exception in vdsm/vm.py

Traceback (most recent call last):
  File "/usr/share/vdsm/vm.py", line 569, in _startUnderlyingVm
    self._run()
  File "/usr/share/vdsm/libvirtvm.py", line 1311, in _run
    devices = self.buildConfDevices()
  File "/usr/share/vdsm/vm.py", line 416, in buildConfDevices
    devices[VIDEO_DEVICES] = self.getConfVideo()
  File "/usr/share/vdsm/vm.py", line 460, in getConfVideo
    'device': devType})

I am a little confused after reading the related code. It seems that there is no obvious way to create a VM without a display device. Can anyone show me the correct conf dict for this purpose?
Line 49:                 'kernel': kernelPath,
Line 50:                 # Fedora uses dracut to create initramfs. The following
Line 51:                 # arguments will be interpreted by init scripts created by
Line 52:                 # dracut.


Line 66:             while True:
Line 67:                 vmUp = self.isVMUp(vmid)
Line 68:                 guestUp = self.isGuestUp(vmid)
Line 69:                 if vmUp and guestUp:
Line 70:                     break
Done
Line 71:                 now = time.time()
Line 72:                 if now - start > timeout:
Line 73:                     raise Exception("Creating VM timeout.\n"
Line 74:                                     "VM Up: %r, Guest Up: %r.\n"


--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list