Change in vdsm[master]: tc: rename qdisc_replace_prio()

asegurap at redhat.com asegurap at redhat.com
Thu Aug 23 10:27:22 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: tc: rename qdisc_replace_prio()
......................................................................


Patch Set 3: Fails; I would prefer that you didn't submit this

(1 inline comment)

On running tcTests, this patch breaks them.

....................................................
File vdsm/tc.py
Line 34:         Exception.__init__(self, self.errCode, self.message, self.command)
Line 35: 
Line 36: def setPortMirroring(network, target):
Line 37:     qdisc_replace_ingress(network)
Line 38:     add_filter(network, target, 'ffff:')
Shouldn't this patch change this line's method as well?
Line 39:     qdisc_replace_parent(network)
Line 40:     devid = qdisc_get_devid(network)
Line 41:     add_filter(network, target, devid)
Line 42:     set_promisc(network, True)


--
To view, visit http://gerrit.ovirt.org/7300
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9628244a144ece23b793e260e077dcee9698eba
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list