Change in vdsm[master]: tc: refine unsetPortMirroring

asegurap at redhat.com asegurap at redhat.com
Thu Aug 23 00:25:47 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: tc: refine unsetPortMirroring
......................................................................


Patch Set 2: (1 inline comment)

I'm in the process of reviewing it, but I honestly could not find what mirred is, so I might miss some semantics of the change.

....................................................
Commit Message
Line 6: 
Line 7: tc: refine unsetPortMirroring
Line 8: 
Line 9: unsetPortMirroring should not remove all reference of the mirrored
Line 10: bridge device. Instead, remove only the relevant mirred actions on each
What is mirred?
Line 11: call to unsetPortMirroring. Promiscuous mode should be unset only when
Line 12: the last action is removed.
Line 13: 
Line 14: Change-Id: I09b315e7398c2293dc6f84ab63853b70308b2875


--
To view, visit http://gerrit.ovirt.org/7299
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09b315e7398c2293dc6f84ab63853b70308b2875
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list