Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

danken at redhat.com danken at redhat.com
Wed Aug 22 19:16:59 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: infra: adding debug log to vdsm daemon init script
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

I think it would be nice if you not only define the function, but also use it - I think it makes sense to call it in log_failure_msg/log_success_msg.

....................................................
File vdsm/vdsmd.init.in
Line 47: SYSTEMCTL_SKIP_REDIRECT=true
Line 48: 
Line 49: . /etc/init.d/functions
Line 50: 
Line 51: debug_log() { [[ -n "$DEBUG" ]] && (echo "$*" >> $DEBUG_LOG) }
I see no point in creating another shell process - that what happens with parentheses.
Line 52: log_failure_msg() { echo -n "$@"; failure "$@"; echo; }
Line 53: log_success_msg() { echo -n "$@"; success "$@"; echo; }
Line 54: 
Line 55: check_port_taken() {


--
To view, visit http://gerrit.ovirt.org/7340
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list