Change in vdsm[master]: test: Add tests for _validateInterNetworkCompatibility()

asegurap at redhat.com asegurap at redhat.com
Wed Aug 22 13:23:17 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: test: Add tests for _validateInterNetworkCompatibility()
......................................................................


Patch Set 2: (2 inline comments)

I like the tests a lot, now it looks much more complete this unit test. Looking very much forward to +1 this patch once the tiny formatting issues are addressed.

....................................................
File tests/configNetworkTests.py
Line 286:         # Test for adding a new VLANed bridged network
Line 287:         # when a non-VLANed bridged network exists
Line 288:         self._addNetworkWithExc((netinfoIns, 'test', '2', 'bond00', nics,
Line 289:                                  ipaddr, netmask, gw, bondingOptions),
Line 290:                                  configNetwork.ne.ERR_BAD_PARAMS)
The indentation is off by one space (see line 284). Idem for lines 297, 303 and 310.
Line 291: 
Line 292:         # Test for adding a new VLANed bridgeless network
Line 293:         # when a non-VLANed bridged network exists
Line 294:         self._addNetworkWithExc((netinfoIns, 'test', '2', 'bond00', nics,


Line 292:         # Test for adding a new VLANed bridgeless network
Line 293:         # when a non-VLANed bridged network exists
Line 294:         self._addNetworkWithExc((netinfoIns, 'test', '2', 'bond00', nics,
Line 295:                                  ipaddr, netmask, gw, bondingOptions,
Line 296:                                  False),
I think we can safely fit the False), in the previous line without reaching the max character number. (The same in the other test).
Line 297:                                  configNetwork.ne.ERR_BAD_PARAMS)
Line 298: 
Line 299:         # Test for adding a new VLANed bridged network
Line 300:         # when the interface is in use by any type of networks


--
To view, visit http://gerrit.ovirt.org/7241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I732c8c9f1983261391835e1e3687cf120e9def34
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list