Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode

dougsland at redhat.com dougsland at redhat.com
Wed Aug 22 03:31:23 UTC 2012


Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: use python scripts from ovirtnode
......................................................................


Patch Set 3: (2 inline comments)

I need to execute new tests, ASAP I will update here.

....................................................
File vdsm_reg/vdsm-upgrade
Line 15: import logging.config
Line 16: from time import strftime
Line 17: from config import config
Line 18: import deployUtil
Line 19: from ovirtnode.install import *
Sure, new patch will fix that.
Line 20: 
Line 21: VDSM_REG_CONF_FILE = '/etc/vdsm-reg/vdsm-reg.conf'
Line 22: VDSM_CONF_FILE = '/etc/vdsm/vdsm.conf'
Line 23: log_filename = '/var/log/vdsm-reg/vds_bootstrap_upgrade.'+strftime("%Y%m%d_%H%M%S")+'.log'


Line 88: def doUpgrade(config):
Line 89:     fReturn = True
Line 90: 
Line 91:     install = Install()
Line 92:     if install.ovirt_boot_setup():
looking the code, I see it's inside a try.
Line 93:         msg = "<BSTRAP component='doUpgrade' status='OK' message='Upgrade Succeeded. Rebooting'/>"
Line 94:         print (msg)
Line 95:         logging.debug(msg)
Line 96:     else:


--
To view, visit http://gerrit.ovirt.org/7074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list