Change in vdsm[master]: Ship the version file with the tarballs

danken at redhat.com danken at redhat.com
Tue Aug 21 18:08:06 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Ship the version file with the tarballs
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File Makefile.am
Line 137: 	fi
Line 138: 
Line 139: gen-VERSION:
Line 140: 	if test -d .git; then					\
Line 141: 	  $(top_srcdir)/build-aux/pkg-version --full		\
yeah, that's indeed better.
Line 142: 	    > $(distdir)/ve-t;					\
Line 143: 	  rm -f $(distdir)/VERSION;				\
Line 144: 	  mv $(distdir)/ve-t $(distdir)/VERSION;		\


--
To view, visit http://gerrit.ovirt.org/7295
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b72a1740803a9401e4b5a4504a4faa07c29f2b9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list