Change in vdsm[master]: BZ#841555 A migration failure with an "AttributeError" excep...

danken at redhat.com danken at redhat.com
Tue Aug 21 12:22:47 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 2438:                 # Libvirt sometimes send the SUSPENDED/SUSPENDED_PAUSED event
Line 2439:                 # after RESUMED/RESUMED_MIGRATED (when VM status is PAUSED
Line 2440:                 # when migration completes, see qemuMigrationFinish function).
Line 2441:                 # In this case self._dom is None because the function
Line 2442:                 # _waitForIncomingMigrationFinish didn't update it yet.
this comment does not reassure me... we are "sometimes" going to get this event after migration, and sometimes not?
Line 2443:                 if self._dom:
Line 2444:                     hooks.after_vm_pause(self._dom.XMLDesc(0), self.conf)
Line 2445:         elif event == libvirt.VIR_DOMAIN_EVENT_RESUMED:
Line 2446:             self._guestCpuRunning = True


--
To view, visit http://gerrit.ovirt.org/6901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list