Change in vdsm[master]: avoid redundant domain produce() in createStoragePool

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Tue Aug 21 01:24:07 UTC 2012


Royce Lv has posted comments on this change.

Change subject: avoid redundant domain produce() in createStoragePool
......................................................................


Patch Set 1:

Ming, my consideration is not the case dom can be find and validate case. 
The first lookup and validate is very early from real use of the domain, domain will not be validate till then. So we just check it when we want to use it in case its validity changed and the first check become wasted.

--
To view, visit http://gerrit.ovirt.org/7347
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1c236aa3043068ca8f3f376cb340e986cd484bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list