Change in vdsm[master]: BZ#811807 Define network filter on libvirt

ilvovsky at redhat.com ilvovsky at redhat.com
Mon Aug 20 18:14:46 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: BZ#811807 Define network filter on libvirt
......................................................................


Patch Set 1: (1 inline comment)

Dan asked to put it in tools, isn't he?

....................................................
File vdsm/vdsmd.init.in
Line 452:             fi
Line 453:             sleep 1
Line 454:         done
Line 455:         # End workaround
Line 456: 
What is this? Why now?
How this related to nwfilter?
If we really need it, I think it should be in different patch
Line 457:         return 0
Line 458:     else
Line 459:         echo "$startout" >&2
Line 460:         return 1


--
To view, visit http://gerrit.ovirt.org/7354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1708385dec6a87bc404e4ab25c4da8ab8a8acc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list