Change in vdsm[master]: vdsm: generating uuid for libvirt configuration (#842115)

danken at redhat.com danken at redhat.com
Mon Aug 20 14:45:31 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: generating uuid for libvirt configuration (#842115)
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

I'm fine with the code, I have few comments on the comment that could use some spell-checking.

....................................................
Commit Message
Line 3: AuthorDate: 2012-08-20 11:44:50 +0300
Line 4: Commit:     Yaniv Bronhaim <ybronhei at redhat.com>
Line 5: CommitDate: 2012-08-20 13:57:18 +0300
Line 6: 
Line 7: vdsm: generating uuid for libvirt configuration (#842115)
until agreed otherwise, vdsm commits should begin with BZ# prefix.
Line 8: 
Line 9: during migration we found that if both hosts as the same uuid
Line 10: libvirt fails the migration. Sometimes host are shipped with
Line 11: non-unique uuid burned into their bios.


Line 9: during migration we found that if both hosts as the same uuid
Line 10: libvirt fails the migration. Sometimes host are shipped with
Line 11: non-unique uuid burned into their bios.
Line 12: this fix generate uniqe uuid for libvirt only during vdsm reconfiguration.
Line 13: this uuid is saved in libvirtd.conf file and is been used after
"is been used"? (English)
Line 14: libvirt service is restarted.
Line 15: 
Line 16: Change-Id: I12478f64850dc3b3e421a562762c020819c8be28


--
To view, visit http://gerrit.ovirt.org/7332
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12478f64850dc3b3e421a562762c020819c8be28
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list