Change in vdsm[master]: Fix a race existing in the singleton interface of clientIF

danken at redhat.com danken at redhat.com
Sun Aug 19 21:32:34 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix a race existing in the singleton interface of clientIF
......................................................................


Fix a race existing in the singleton interface of clientIF

There's a race in getInstance() between clientIF initialization and MOM thread.
If for some reason the initialization of clientIF is slowed down and not finished
before MOM calls vdsm API, an exception will happen in MOM thread due to that
the parameter 'log' is missing. The fix is just moving the parameter check into
the protection of the singleton lock. Then MOM thread will be blocked if it tries
to access vdsm API when the initialization of clientIF is ongoing.

Change-Id: I6d907f5613963438c99749da674bb6588a23fe38
Signed-off-by: Mark Wu <wudxw at linux.vnet.ibm.com>
---
M vdsm/clientIF.py
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Adam Litke: Verified; Looks good to me, but someone else must approve
  Royce Lv: Looks good to me, but someone else must approve
  Mark Wu: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7283
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d907f5613963438c99749da674bb6588a23fe38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list