Change in vdsm[master]: BZ#848299 - Fix delete VLANed network with custom MTU

danken at redhat.com danken at redhat.com
Sun Aug 19 10:21:37 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#848299 - Fix delete VLANed network with custom MTU
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 582:         for vlan in vlans:
Line 583:             if vlan == delvlan:
Line 584:                 continue
Line 585:             iface = iface + '.' + vlan
Line 586:             cf = netinfo.NET_CONF_DIR + iface
this has to be NET_CONF_PREF. who is going to add "ifcfg-" to the file name?
Line 587:             mtu = self._getConfigValue(cf, 'MTU')
Line 588:             newmtu = max(newmtu, mtu)
Line 589: 
Line 590:         if newmtu != currmtu:


--
To view, visit http://gerrit.ovirt.org/7214
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I485c8bd3dfa84c421dab2c5d121ad7a5efc348a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list