Change in vdsm[master]: bootstrap: return proper exit code from bootstrap scripts

danken at redhat.com danken at redhat.com
Sat Aug 18 21:00:29 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: bootstrap: return proper exit code from bootstrap scripts
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

script returning a boolean instead of the expected 0-127 integer is quite ugly. oh well, at least we are consistent. ack.

but one request inside.

....................................................
File vds_bootstrap/setup
Line 173:                     execfn += [random_num]
Line 174:                 execfn.append(str(int(rebootAfterInstallation)))
Line 175:             logging.debug("trying to run %s script cmd = '%s'",script, string.join(execfn, " "))
Line 176:             proc = subprocess.Popen(execfn)
Line 177:             proc.communicate()
would you please please please capture stderr and log it, and report it to Engine in the improbable case of an error?
Line 178:             if proc.returncode == 0:
Line 179:                 return True
Line 180:         else:
Line 181:             logging.debug("script %s doen not exist",script)


--
To view, visit http://gerrit.ovirt.org/7301
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf1d2ad402641394da52099c157fc34cf49cad1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list