Change in vdsm[master]: bootstrap: send complete bootstrap from engine

Alon Bar-Lev alonbl at redhat.com
Sat Aug 18 18:05:38 UTC 2012


Alon Bar-Lev has posted comments on this change.

Change subject: bootstrap: send complete bootstrap from engine
......................................................................


Patch Set 15: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 210:             '/req_%s.conf' % random_num,
Line 211:             '/cert_%s.req' % random_num,
Line 212:             '/cert_%s.pem' % random_num,
Line 213:             '/CA_%s.pem' % random_num,
Line 214:             '/ovirt-id_rsa_%s' % random_num
It should not exist after execute in any interface... why make code more complex?
Line 215:         ):
Line 216:             os.unlink(_WORK_DIR + f)
Line 217:     except:
Line 218:         pass


--
To view, visit http://gerrit.ovirt.org/6962
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list