Change in vdsm[master]: Ship the version file with the tarballs

danken at redhat.com danken at redhat.com
Fri Aug 17 21:09:17 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Ship the version file with the tarballs
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

thanks for attending to this packaging issue. One or two questions within.

....................................................
File Makefile.am
Line 137: 	fi
Line 138: 
Line 139: gen-VERSION:
Line 140: 	if test -d .git; then					\
Line 141: 	  git describe > $(distdir)/ve-t;			\
have you intentionally dropped the

 --match "v[0-9]*"

argument to git-describe? it helps against local tags hiding the "real" ones.
Line 142: 	  rm -f $(distdir)/VERSION;				\
Line 143: 	  mv $(distdir)/ve-t $(distdir)/VERSION;		\


Line 139: gen-VERSION:
Line 140: 	if test -d .git; then					\
Line 141: 	  git describe > $(distdir)/ve-t;			\
Line 142: 	  rm -f $(distdir)/VERSION;				\
Line 143: 	  mv $(distdir)/ve-t $(distdir)/VERSION;		\
you are creating a real file here, so why use .PHONY targets? (oops, I see it's not the first time... I still wonder why)


--
To view, visit http://gerrit.ovirt.org/7295
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b72a1740803a9401e4b5a4504a4faa07c29f2b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list