Change in vdsm[master]: DomainMonitor should use use real domains (no proxy)

abaron at redhat.com abaron at redhat.com
Fri Aug 17 21:04:40 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: DomainMonitor should use use real domains (no proxy)
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

What's the difference between this patch and Eduardo's patch which moved the produce into domain monitor?

....................................................
File vdsm/storage/sp.py
Line 1021: 
Line 1022:         if targetFormat is None:
Line 1023:             targetFormat = self.getFormat()
Line 1024: 
Line 1025:         self._formatConverter.convert(repoPath, self.id, domain, isMsd,
wasn't getRealDomain method removed in previous patch? if so then previous patch is not self contained and breaks things? i.e. this fix should have been there as well, no?
Line 1026:                                       targetFormat)
Line 1027:         sdCache.manuallyRemoveDomain(sdUUID)
Line 1028: 
Line 1029:     @unsecured


--
To view, visit http://gerrit.ovirt.org/7294
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbf67fc050658e3418aa666e8fcef1e1244571e9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list