Change in vdsm[master]: bootstrap: send complete bootstrap from engine

Alon Bar-Lev alonbl at redhat.com
Fri Aug 17 20:49:36 UTC 2012


Alon Bar-Lev has posted comments on this change.

Change subject: bootstrap: send complete bootstrap from engine
......................................................................


Patch Set 13: (3 inline comments)

....................................................
File vds_bootstrap/setup
Line 1: #!/usr/bin/python
Line 2: #
Line 3: # Copyright 2008-2012 Red Hat, Inc.
I thought about this, however, adding non working file as commit is also not too great.
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
Line 6: # it under the terms of the GNU General Public License as published by
Line 7: # the Free Software Foundation; either version 2 of the License, or


Line 36: vdsm_reg_conf_file = '/etc/vdsm-reg/vdsm-reg.conf'
Line 37: 
Line 38: #
Line 39: # bootstrap<->engine interface version
Line 40: # 1 = <engine-3.1
This is why I did not want to document this... but someone insisted.
Line 41: # 2 = engine-3.1
Line 42: #
Line 43: bootstrap_interface_version = 2
Line 44: 


....................................................
File vdsm_reg/deployUtil.py.in
Line 206:             '/req_%s.conf' % random_num,
Line 207:             '/cert_%s.req' % random_num,
Line 208:             '/cert_%s.pem' % random_num,
Line 209:             '/CA_%s.pem' % random_num,
Line 210:             '/ovirt-id_rsa_%s' % random_num
The engine, instead of script fetching this using HTTP.
Line 211:         ):
Line 212:             os.unlink(_WORK_DIR + f)
Line 213:     except:
Line 214:         pass


--
To view, visit http://gerrit.ovirt.org/6962
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list