Change in vdsm[master]: Added glusterVolumeStatus verb

danken at redhat.com danken at redhat.com
Thu Aug 16 20:04:13 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added glusterVolumeStatus verb
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/gluster/cli.py
Line 123:                                      'pid': value['pid']})
Line 124:     return status
Line 125: 
Line 126: 
Line 127: def _parseGlusterVolumeStatusDetail(tree):
I'd appreciate a unit test for these new functions.
Line 128:     status = {
Line 129:         'name': tree.find('volStatus/volName').text,
Line 130:         'bricks': []
Line 131:         }


Line 173:     return status
Line 174: 
Line 175: 
Line 176: @exportToSuperVdsm
Line 177: def volumeStatus(volumeName, option=None):
please add a docstring detailing valid options, and what this new verb does.
Line 178:     command = _getGlusterVolCmd() + ["status", volumeName]
Line 179:     if option:
Line 180:         command.append(option)
Line 181:     err, res = _execGluster(command, xml=True)


--
To view, visit http://gerrit.ovirt.org/6374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8769c2da299a598ed7500c4780a3329972f4a8ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbellur at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list