Change in vdsm[master]: [WIP]Add text-based console support

Xu He Jie xuhj at linux.vnet.ibm.com
Thu Aug 16 07:37:13 UTC 2012


Xu He Jie has posted comments on this change.

Change subject: [WIP]Add text-based console support
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/consoleServer.py
Line 53:                     continue
Line 54:                 finally:
Line 55:                     servSock.close()
Line 56: 
Line 57:                 self._bitmap[i] = 0x1
there is a race problem
Line 58:                 return i + self._minPort
Line 59: 
Line 60:         raise Exception("Can not free port on address: %s", addr)
Line 61: 


Line 54:                 finally:
Line 55:                     servSock.close()
Line 56: 
Line 57:                 self._bitmap[i] = 0x1
Line 58:                 return i + self._minPort
SSHConsoleServer is started after setTicket. so the port is used after setTicket. If there is another VM created between the port allocation and setTicket, It can't check the port had already allocated to other VM by 'bind'. 

But there still have problem if the port used by other application between port allocation and setTicket, SSHConsoleServer will startup failed. I am trying to find a way to resolve it.
Line 59: 
Line 60:         raise Exception("Can not free port on address: %s", addr)
Line 61: 
Line 62:     def freePort(self, port):


--
To view, visit http://gerrit.ovirt.org/7165
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69904bf7aafd4f764a256d4075c9bf71d988e7c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list