Change in vdsm[master]: Move fenceNode out of API.py

smizrahi at redhat.com smizrahi at redhat.com
Wed Aug 15 21:11:44 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Move fenceNode out of API.py
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm/BindingXMLRPC.py
Line 361:         secure = utils.tobool(secure)
Line 362:         port = int(port)
Line 363: 
Line 364:         if action == "status":
Line 365:             try:
No, What belongs here is backward compatibility glue code until we throw away this modules.

Because the status action returns a completely different response and has different logic it will be a separate call in the new API.
Line 366:                 power = fenceAgent.getFenceStatus(addr, port, agent, username,
Line 367:                         password, secure, options)
Line 368: 
Line 369:                 return {'status': doneCode,


Line 369:                 return {'status': doneCode,
Line 370:                         'power': power}
Line 371: 
Line 372:             except fenceAgent.FenceStatusCheckError as e:
Line 373:                 return {'status': {'code': 1, 'message': str(e)}}
This is problematic as it binds the modules to the bindings.
If we want to change the codes for the new bindings there will be no way to do that.
Line 374: 
Line 375:         try:
Line 376:             fenceAgent.fenceNode(addr, port, agent, username, password, secure,
Line 377:                 options, self.cif.shutdownEvent)


--
To view, visit http://gerrit.ovirt.org/7191
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idaba551333a0f289abaff11dc113e09c426d591a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list