Change in vdsm[master]: Fix vdsm-faqemu VM launch failure on hosts with newer libvir...

Ryan Harper ryanh at us.ibm.com
Wed Aug 15 20:20:38 UTC 2012


Ryan Harper has uploaded a new change for review.

Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt
......................................................................

Fix vdsm-faqemu VM launch failure on hosts with newer libvirt

Since January 2012, libvirt now checks[1] for the presence of /dev/kvm before
starting a VM to generate better error messages when a VM doesn't start.
This breaks faqemu running in a VM (non-nested) or a host which doesn't have KVM
modules loaded.  Work around this by touching the device node.

1. libvirt commit hash 32f63e912d3bef42a7fa70a0f2d5b04b98afe936

Change-Id: I1dc88f2931e8f716c1732a51d9f65f600f4fd1ef
Signed-off-by: Ryan Harper <ryanh at us.ibm.com>
---
M vdsm_hooks/faqemu/vdsm-faqemu
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/7223/1

diff --git a/vdsm_hooks/faqemu/vdsm-faqemu b/vdsm_hooks/faqemu/vdsm-faqemu
index 218af7f..a36a87c 100644
--- a/vdsm_hooks/faqemu/vdsm-faqemu
+++ b/vdsm_hooks/faqemu/vdsm-faqemu
@@ -19,4 +19,7 @@
     qemu_argv += [ "-no-kvm" ]
 
 qemu_argv += filter(lambda x: x != "-enable-kvm", sys.argv[1:])
+# libvirt 0.9.10+ checks for the presence of /dev/kvm to provide 
+# better error messages, but this breaks this hook, fake it out
+os.system("touch /dev/kvm")
 os.execv(qemu_bin, qemu_argv)


--
To view, visit http://gerrit.ovirt.org/7223
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1dc88f2931e8f716c1732a51d9f65f600f4fd1ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list