Change in vdsm[master]: Move fencing logic out of API.py
agl at us.ibm.com
agl at us.ibm.com
Wed Aug 15 16:17:51 UTC 2012
Adam Litke has posted comments on this change.
Change subject: Move fencing logic out of API.py
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/API.py
Line 1020
Line 1021
Line 1022
Line 1023
Line 1024
Shouldn't the code be more meaningful than always setting it to 1? Eventually we are going to want a formalized set of error codes as part of the schema. It is probably a separate patch, but an issue nonetheless.
--
To view, visit http://gerrit.ovirt.org/7190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list