Change in vdsm[master]: fix TypeError of _eqSplit in vdsClient.py

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Wed Aug 15 11:00:03 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: fix TypeError of _eqSplit in vdsClient.py
......................................................................


Patch Set 1: (1 inline comment)

IMO, for bool options, such as "xx=Ture" and "xx" should the same.
if we drop the whole "if",it will pick up "xx=Ture" but drop the "xx".

....................................................
File vdsm_cli/vdsClient.py
Line 1407:             kv = arg.split('=', 1)
Line 1408:             if len(kv) == 2:
Line 1409:                 k, v = kv
Line 1410:             else:
Line 1411:                 k, v = kv[0], ''
now I want to add new command.

I want to the command like this:

vdsClient 0 command xx=Ture

but I think

vdsClient 0 command xx

is also OK.

we can omit “=Ture”. although it is a lazy command calling.
Line 1412:             d[k] = v
Line 1413:         return d
Line 1414: 
Line 1415:     def _splitDriveSpecItems(self, item):


--
To view, visit http://gerrit.ovirt.org/7200
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98b5573499adaa1b64f8343b445cc16df8f60f3d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list