Change in vdsm[master]: bootstrap: sync logging between two phases

danken at redhat.com danken at redhat.com
Tue Aug 14 20:12:05 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: bootstrap: sync logging between two phases
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

for visibility

....................................................
File vds_bootstrap/vds_bootstrap_complete.py
Line 41: 
Line 42: try:
Line 43:     import deployUtil
Line 44: except:
Line 45:     message = "Error trying to deploy library."
yeah, I believe it would be better to drop this test from the two locations - but add a single place in vds_installer.py where the traceback of vds_bootsrap is collected and reported to Engine as error.

this would be a grand step forward in debugability of these scripts.
Line 46:     print ("<BSTRAP component='INIT' status='FAIL' message='%s'/>" % message)
Line 47:     logging.debug("<BSTRAP component='INIT' status='FAIL' message='%s'/>", message)
Line 48:     logging.error(message, exc_info=True)
Line 49:     exit(-1)


--
To view, visit http://gerrit.ovirt.org/7089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3faeeaa9e85d92e1d8bcec6517745a665a3da8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list