Change in vdsm[master]: Offset by one for UUID position

dougsland at redhat.com dougsland at redhat.com
Tue Aug 14 17:41:41 UTC 2012


Douglas Schilling Landgraf has posted comments on this change.

Change subject: Offset by one for UUID position
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Dan, made the comment because I originally made this change before 3.0 get released. Please see my comment.

....................................................
File vdsm/storage/fileSD.py
Line 61:     # sdUUID position after data-center
Line 62:     sdUUIDPos = 3
Line 63: 
Line 64:     metaList = metafile.split('/')
Line 65:     sdUUID = len(os.path.normpath(config.get('irs', 'repository')).split('/')) - 1 + sdUUIDPos
I would change the sdUUIDPos variable instead to add -1. However, could you please clarify how did you get this problem? Looks like you are the first one.
Line 66:     return metaList[sdUUID]
Line 67: 
Line 68: class FileMetadataRW(object):
Line 69:     """


--
To view, visit http://gerrit.ovirt.org/7078
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list