Change in vdsm[master]: BZ#832765 - Rewrite vdsm-restore-net-config as python module

ilvovsky at redhat.com ilvovsky at redhat.com
Tue Aug 14 14:08:16 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm/vdsm-restore-net-config
Line 29:     # this should NOT be used in ovirt-node, where configuration persistence is
Line 30:     # handled otherwise.
Line 31:     try:
Line 32:         if os.path.exists('/etc/rhev-hypervisor-release') or \
Line 33:            not len(glob.glob('/etc/ovirt-node-*-release')) == 0:
unfortunately we already have this check in several different places in vdsm (except deployUtil) and you are absolutely right, it will be good to gather it in some common place
(we already spoke with Dan about it)

I just don't want to mix it with this patch series, it's a long series that fix network's rollback.
But, we will do it in different patch
Line 34:                 return
Line 35:     except:
Line 36:         pass
Line 37: 


--
To view, visit http://gerrit.ovirt.org/6991
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list