Change in vdsm[master]: BZ#832765 - Rewrite vdsm-restore-net-config as python module

mburns at redhat.com mburns at redhat.com
Tue Aug 14 12:54:14 UTC 2012


Michael Burns has posted comments on this change.

Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module
......................................................................


Patch Set 7: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vdsm-restore-net-config
Line 26: 
Line 27: def main():
Line 28:     # this should NOT be used in ovirt-node, where configuration persistence is
Line 29:     # handled otherwise.
Line 30:     if os.path.exists('/etc/rhev-hypervisor-release'):
for upstream ovirt-node, it's always ovirt-node-iso-release or ovirt-node-image-release.  For RHEV-H builds, it's rhev-hypervisor-release

For this check, there is an isOvirt function somewhere that should work already.
Line 31:         return
Line 32: 
Line 33:     configWriter = configNetwork.ConfigWriter()
Line 34:     configWriter.loadBackups()


--
To view, visit http://gerrit.ovirt.org/6991
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68d07e3754305dfc7e02d67c59b7c801b9d80bc5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list