Change in vdsm[master]: bootstrap: introduce bootstrap interface version

dougsland at redhat.com dougsland at redhat.com
Tue Aug 14 00:44:30 UTC 2012


Douglas Schilling Landgraf has posted comments on this change.

Change subject: bootstrap: introduce bootstrap interface version
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 51: import socket
Line 52: import tempfile
Line 53: from time import strftime
Line 54: 
Line 55: bootstrap_interface_version = 1
I still think we need a comment here explaining what's  	bootstrap_interface_version and it's value, even if you are about to rewrite this code.
Line 56: 
Line 57: # set logging before deployUtil is first used
Line 58: try:
Line 59:     LOGDIR=os.environ["OVIRT_LOGDIR"]


Line 940:     """
Line 941: Usage: vds_bootstrap.py [options] <url> <subject> <random_num>
Line 942: 
Line 943: options:
Line 944:     -v <bootstrap inteface version> - default 1
default 1 doesn't say too much about this option...
Line 945:     -O <organizationName>
Line 946:     -t <systemTime>
Line 947:     -f <firewall_rules_file> -- override firewall rules.
Line 948:     -V - don't install virtualization service


--
To view, visit http://gerrit.ovirt.org/7092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67b92dce5896a5cf510ffc0d51450e56070eb03e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list