Change in vdsm[master]: vdsm bootstrap changes for kvm on ppc64 support
dougsland at redhat.com
dougsland at redhat.com
Mon Aug 13 20:18:14 UTC 2012
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
Hi Pradipta,
Reviewing again the code, I have additional questions. Sorry that I didn't find it in my previous comment.
....................................................
File vdsm_reg/deployUtil.py.in
Line 403:
Line 404: Return "Unknown Arch" on any failure.
Line 405: """
Line 406:
Line 407: s = ''
can we have a long variable name? maybe platformArch or other that you prefer.
Line 408: try:
Line 409: s = platform.machine()
Line 410: logging.debug("Platform Arch = %s", s)
Line 411: return s
Line 419:
Line 420: Return "Unknown OS" on any failure.
Line 421: """
Line 422:
Line 423: s = ''
Can we have a long variable name here? maybe osName or other that you prefer?
Line 424: try:
Line 425: s = platform.dist()
Line 426: logging.debug("OS Name = %s", s[0])
Line 427: return s[0]
Line 421: """
Line 422:
Line 423: s = ''
Line 424: try:
Line 425: s = platform.dist()
Looks like dist() is deprecated since version 2.6. Is it possible to use linux_distribution()? http://docs.python.org/library/platform.html
Line 426: logging.debug("OS Name = %s", s[0])
Line 427: return s[0]
Line 428: except:
Line 429: logging.error('failed to get OS name')
--
To view, visit http://gerrit.ovirt.org/7072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ca5dc3adba6183657afed778f999715ee332e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list