Change in vdsm[master]: Bz#839919 remoteFileHandler.py: Add storage into python path

smizrahi at redhat.com smizrahi at redhat.com
Mon Aug 13 16:39:49 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Bz#839919 remoteFileHandler.py: Add storage into python path
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/remoteFileHandler.py
Line 46:     from vdsm.betterPopen import BetterPopen
Line 47:     from vdsm import constants
Line 48: # We add the parent directory so that imports that import the storage
Line 49: # package would work even though CWD is inside the storage package.
Line 50: sys.path.append(os.path.dirname(os.path.abspath(__file__)))
Isn't this the current directory? The original code adds the parent directory
Line 51: 
Line 52: 
Line 53: class Timeout(RuntimeError):
Line 54:     pass


--
To view, visit http://gerrit.ovirt.org/6354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id23c3d0be6eb2e2212172613ea8f3b0c58edce06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list