Change in vdsm[master]: bootstrap: send complete bootstrap from engine

danken at redhat.com danken at redhat.com
Thu Aug 9 20:32:22 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: bootstrap: send complete bootstrap from engine
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(6 inline comments)

partial review, good night.

....................................................
Commit Message
Line 27: tarball name has interface version so several versions may be provided
why a tarball instead of a plain rpm? why do we need the additional layer of encapsulation? why bootstrap-1 and bootstrap-2 are shipped within the same rpm?

....................................................
File vds_bootstrap/Makefile.am
Line 31: # old servers to use upgraded package
server -> engine. right?

....................................................
File vds_bootstrap/vds_bootstrap_complete.py
Line 73:             if o == "-v":
maybe it's time to use longopts? -v and -V are a bit confusing due to they inrelatedness.

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 62:                     filename='/tmp/vdsm-bootstrap-phase1.%s.log' % (strftime("%Y%m%d%H%M%S")),
please keep new code in shorter lines.

outer parens in

 (strftime("%Y%m%d%H%M%S"))

are meaningless

Line 741:         global bootstrap_interface_version
you do not need to declare this as global if you do not attempt to change it.

....................................................
File vdsm_reg/deployUtil.py.in
Line 60: _WORK_DIR = "/tmp"    # hardcoded as server use it as-is
why are you reverting the good of directory generalization?

--
To view, visit http://gerrit.ovirt.org/6962
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01ddee19cbb65341ed22435ed9e735a0ad3c2abd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list