Change in vdsm[master]: call sync before umount in mkFloppyFs

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Wed Aug 8 07:41:11 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: call sync before umount in mkFloppyFs
......................................................................


Patch Set 1: (1 inline comment)

Mark Wu, the problem is in the function "mkFloppyFs" in "vdsm/mkimage.py", not in the test case. The test case just calls "mkFloppyFs" and fail, so we can know there is a problem. As we write more test cases, we may reveal the same problem in other vdsm source files, so we may want to call sync in other files, that's why I add a function.

....................................................
File vdsm/mkimage.py
Line 86:             storage.misc.syncFileSystem()
Yes. Otherwise other programmers will get confused.

--
To view, visit http://gerrit.ovirt.org/6995
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I708e70aa1e898b32bb3c1009d411389d7adbe549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list