Change in vdsm[master]: BZ# - Fix virtio hotplug disk fail to a VM with IDE disks.

danken at redhat.com danken at redhat.com
Tue Aug 7 12:23:21 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ# - Fix virtio hotplug disk fail to a VM with IDE disks.
......................................................................


Patch Set 1: (1 inline comment)

it smells that you should maintain the list of used nics.

....................................................
File vdsm/vm.py
Line 530:         if not self._usedIndices.has_key(drv['iface']):
pep8 dislikes has_key(). use "not in" instead.

--
To view, visit http://gerrit.ovirt.org/6970
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f9a317dd07f3fb8f69ecf4c647e91e5e9064dc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list