Change in vdsm[master]: Add permutation feature to testing framework

danken at redhat.com danken at redhat.com
Mon Aug 6 20:09:11 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Add permutation feature to testing framework
......................................................................


Patch Set 11: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 7: Add permutation feature to testing framework
It took me way too much time to understand what is this feature, and that I actually want it! Please drop a word about it being a tool to write a single test case template that is mutated into several actual test cases.

....................................................
File tests/testrunner.py
Line 49: def expandPermutations(cls):
why not have it in all VdsmTestCase? I find it boring to add this class decorator for every class that has a test case with @permutations.

Line 70: def permutations(permutations):
a function and its args sharing a name. does this have a benefit beyond confusing me?

--
To view, visit http://gerrit.ovirt.org/6244
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26871027182a151fd63c381879e72255f6161695
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list