Change in vdsm[master]: configNetwork: add restoreAtomicNetworkBackup
danken at redhat.com
danken at redhat.com
Mon Aug 6 10:20:24 UTC 2012
Dan Kenigsberg has posted comments on this change.
Change subject: configNetwork: add restoreAtomicNetworkBackup
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/configNetwork.py
Line 195: def removeLibvirtNetwork(self, network, backup=True):
for symmetry, please split to a locate _removeNetwork without backup. this function should ALWAYS back up.
Line 260: if not self._networksBackups:
this condition is not required
--
To view, visit http://gerrit.ovirt.org/6915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I132aa07c6fa2d0bd56ab5a6a79134aed4d0bfb85
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
More information about the vdsm-patches
mailing list