Change in vdsm[master]: Replace calling setSchedulerParameters() with filling its XM...

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon Aug 6 09:57:26 UTC 2012


Mark Wu has posted comments on this change.

Change subject: Replace calling setSchedulerParameters() with filling its XML description.
......................................................................


Patch Set 1: (3 inline comments)

....................................................
Commit Message
Line 11: libvirt call on VM statup.
Done

....................................................
File vdsm/libvirtvm.py
Line 704:         if 'cpuPinning' in self.conf or 'nice' in self.conf:
Yes,  in original implementation, a default value 0 was assigned if it's missing in conf.
That means the default cpu share is 1020,  which is calculated from (20 - 0) * 51. 
Actually,  the default cpu share of each process on system is 1024. For example, you could see 
 /sys/fs/cgroup/cpu/system/libvirtd.service/libvirt/cpu.shares.  So in the new implementation,  the cpu share of all vms without 'nice' in conf  are 1024.  That almost has the same effect to original implementation.  So I think that's fine.

Line 709:             for cpuPin in cpuPinning.keys():
It's possible. But this case is already covered. If no 'cpuPinning',  cpuPinning is assigned to {},  so it will execute the for loop

--
To view, visit http://gerrit.ovirt.org/6290
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I211e191022f5a18fa7d97d5a8fb42e10729ddd06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>


More information about the vdsm-patches mailing list