Change in vdsm[master]: Add atomic/persist backup capabilities for logical networks

danken at redhat.com danken at redhat.com
Mon Aug 6 09:54:13 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Add atomic/persist backup capabilities for logical networks
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

I think we can define a helper function

 def writeBackupFile(dirName, fileName, content)

....................................................
File vdsm/configNetwork.py
Line 217:             logging.debug('failed to get libvirt network %s', netName,
please remove this logging line. it only adds log news, as the exception is re-raised.

Line 239:         backup = os.path.join(netinfo.NET_LOGICALNET_CONF_BACK_DIR, network)
you are correct - this should better be factored out into a separate function, used by _persistentBackup(), too.

--
To view, visit http://gerrit.ovirt.org/6913
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9be3e7e7efc8b8ca3781e953f52bda59b8d37cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>


More information about the vdsm-patches mailing list