Change in vdsm[master]: BZ#840407 - Create a fake template when moving to backup SD.

danken at redhat.com danken at redhat.com
Sun Aug 5 13:17:55 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#840407 - Create a fake template when moving to backup SD.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1338:         pool = self.getPool(spUUID) #Validates that the pool is connected. WHY?
I would have found the code clearer if you would have created the fake template here, before calling validateImageMove? Are we sure that when we ignore ImageDoesNotExistInSD, the ImageMove is valid?

--
To view, visit http://gerrit.ovirt.org/6519
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbeef2480e03cc075b80880485739139e496d0b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list