Change in vdsm[master]: engine.py: fix nodeCleanup() order call

danken at redhat.com danken at redhat.com
Sun Aug 5 10:27:12 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() order call
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 12: cacert.pem and TUI will break next time someone try to register oVirt Engine.
so why not clean the node only after a new certificate has been received?

it's not a real -1, you can provide an explanation in the commit message if you consider the code as correct.

--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list